Skip to content

ir/adm: use deleteNode method to forcefully drop node#3737

Merged
roman-khimov merged 1 commit intomasterfrom
fix-node-removal
Dec 12, 2025
Merged

ir/adm: use deleteNode method to forcefully drop node#3737
roman-khimov merged 1 commit intomasterfrom
fix-node-removal

Conversation

@roman-khimov
Copy link
Member

updateStateIR is gone in contracts since nspcc-dev/neofs-contract#556 (0.26.0 changeset), so it no longer works. Fixes test failure:

2025-12-12T13:37:24.776Z	warn	innerring/network.go:106	external request: can't invoke updateSateIR method in netmap	{"node pub key": "ed92cf9dde91bf35d7d806130ce7c22cbdb639dbb59e77b0fb87287359cbf88dcb6d7faf4cf86b4c1a928b74601dbda357445ffd0baa36a29bc16be0cc5b737f", "error": "chain/client: contract execution finished with state FAULT; exception: at instruction 76 (SYSCALL): System.Contract.Call failed: method not found: updateStateIR/2"}

updateStateIR is gone in contracts since nspcc-dev/neofs-contract#556
(0.26.0 changeset), so it no longer works. Fixes test failure:

    2025-12-12T13:37:24.776Z	warn	innerring/network.go:106	external request: can't invoke updateSateIR method in netmap	{"node pub key": "ed92cf9dde91bf35d7d806130ce7c22cbdb639dbb59e77b0fb87287359cbf88dcb6d7faf4cf86b4c1a928b74601dbda357445ffd0baa36a29bc16be0cc5b737f", "error": "chain/client: contract execution finished with state FAULT; exception: at instruction 76 (SYSCALL): System.Contract.Call failed: method not found: updateStateIR/2"}

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.59%. Comparing base (23b2192) to head (06356d1).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../neofs-adm/internal/modules/fschain/remove_node.go 0.00% 2 Missing ⚠️
pkg/innerring/network.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3737      +/-   ##
==========================================
- Coverage   26.59%   26.59%   -0.01%     
==========================================
  Files         656      656              
  Lines       41552    41552              
==========================================
- Hits        11051    11050       -1     
- Misses      29483    29484       +1     
  Partials     1018     1018              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov roman-khimov merged commit 2d2b436 into master Dec 12, 2025
18 of 22 checks passed
@roman-khimov roman-khimov deleted the fix-node-removal branch December 12, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants