metabase: drop v3->v4 and v4->v5 migrations#3735
Merged
roman-khimov merged 1 commit intomasterfrom Dec 12, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3735 +/- ##
==========================================
- Coverage 26.84% 26.48% -0.37%
==========================================
Files 658 658
Lines 41814 41621 -193
==========================================
- Hits 11225 11022 -203
- Misses 29554 29588 +34
+ Partials 1035 1011 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It's time. 0.49.0 dropped v2 to v3 and 0.50.0 dropped pre-0.46.0 write cache migrations. We also have contracts in master that require 0.46.0+, so this brings metabase more in line with other things. Signed-off-by: Roman Khimov <roman@nspcc.ru>
8864a0d to
a152d09
Compare
carpawell
approved these changes
Dec 12, 2025
| unusedTombstonePrefix | ||
| // unusedSmallPrefix was deleted in metabase version 5 | ||
| unusedSmallPrefix | ||
| unusedSmallPrefix //nolint:unused |
Member
Author
There was a problem hiding this comment.
Never? We kinda can reuse them, but VERSION.md remembers everything.
Member
There was a problem hiding this comment.
yeah, but why need unused consts? not in VERSION.md but in the code
Member
Author
There was a problem hiding this comment.
It's an enumeration and there are still (or can be) constants that come after unused ones, these should work. It can be solved in unnamed fashion, but the way we have them now works too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's time. 0.49.0 dropped v2 to v3 and 0.50.0 dropped pre-0.46.0 write cache migrations. We also have contracts in master that require 0.46.0+, so this brings metabase more in line with other things.