Merged
Conversation
1. We always have notary in FS chain. 2. Processor updates IR list via UpdateNeoFSAlphabetList() which means it uses RoleManagement and NeoFSAlphabet role there. 3. SN unconditionally uses the list from RoleManagement. 4. IR storage in netmap contract is long deprecated. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
carpawell
approved these changes
Nov 28, 2025
| } else { | ||
| irf = NewIRFetcherWithoutNotary(server.netmapClient) | ||
| } | ||
| var irf = NewIRFetcherWithNotary(server.fsChainClient) |
Member
There was a problem hiding this comment.
- it may not be an interface now (but ok to be that)
- it is used in a single constructor, no need to have a separate var now
Member
Author
There was a problem hiding this comment.
The variable is used twice, that's exactly why it's still a variable. I thought of removing this interface completely, but currently it's the same as SNs use, so some symmetry can be helpful.
cthulhu-rider
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.