Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3701 +/- ##
==========================================
- Coverage 27.20% 27.17% -0.03%
==========================================
Files 659 659
Lines 42008 42081 +73
==========================================
+ Hits 11428 11437 +9
- Misses 29516 29582 +66
+ Partials 1064 1062 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d9e23a3 to
c9154e5
Compare
|
|
||
| res, err := c.client.TestInvokeIterator(listMethod, iteratorPrefetchNumber, rawIdUser) | ||
| res, err := c.client.TestInvokeIterator(mtd, iteratorPrefetchNumber, args...) | ||
| if err != nil && isMethodNotFoundError(err, mtd) { |
There was a problem hiding this comment.
why do we need to expect missing methods? i have never done this and relied on contract updates (which are done in the same repo now)
There was a problem hiding this comment.
cuz otherwise SN would have to check min versions of contracts before launching
i have never done this and relied on contract updates
too naive to me, contract are not managed by SN
although i understand this'd be a bit easier
| func subscribeToContainerTransfer(c *cfg, h func(id cid.ID, from, to user.ID)) { | ||
| const eventName = "Transfer" | ||
| registerEventParserOnceContainer(c, eventName, containerEvent.RestoreTransfer) | ||
| addContainerAsyncNotificationHandler(c, eventName, func(e event.Event) { |
There was a problem hiding this comment.
can there be problems related to async owner changes?
There was a problem hiding this comment.
actions are idempotent now
There was a problem hiding this comment.
i meant if there are two transfers close in time, can the cache inside SN has a race with undefined results?
There was a problem hiding this comment.
yes, only listing cache. It was like that before
6350723 to
2ddb63e
Compare
2ddb63e to
3e36bd6
Compare
|
Rebase, please. |
If new methods are missing, SN falls back to the old one. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This makes SN to listen to container NEP-11 transfer events and update GET/LIST caches. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
3e36bd6 to
97e0b2c
Compare
No description provided.