Skip to content

blockchain: enable session iterator expansion#3695

Merged
cthulhu-rider merged 1 commit intomasterfrom
enable-session-expansion
Nov 24, 2025
Merged

blockchain: enable session iterator expansion#3695
cthulhu-rider merged 1 commit intomasterfrom
enable-session-expansion

Conversation

@roman-khimov
Copy link
Member

It's more effective (one request less), especially for SNs using this embedded CN RPC. This feature was introduced in NeoGo 0.109.0 and it requires at least the same client version, but we have it everywhere already.

What do you think, @AnnaShaleva?

@codecov
Copy link

codecov bot commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.31%. Comparing base (df67c62) to head (60e2884).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/innerring/internal/blockchain/blockchain.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3695      +/-   ##
==========================================
+ Coverage   27.30%   27.31%   +0.01%     
==========================================
  Files         658      658              
  Lines       41857    41859       +2     
==========================================
+ Hits        11429    11435       +6     
+ Misses      29365    29362       -3     
+ Partials     1063     1062       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely ACK from my side, but note that the client version should also be upgraded to 0.109.0+ to properly use this feature.

It's more effective (one request less), especially for SNs using this
embedded CN RPC. This feature was introduced in NeoGo 0.109.0 and it requires
at least the same client version, but we have it everywhere already.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov force-pushed the enable-session-expansion branch from 457ef6e to 60e2884 Compare November 24, 2025 11:59
@cthulhu-rider cthulhu-rider merged commit 5301e7e into master Nov 24, 2025
21 of 22 checks passed
@cthulhu-rider cthulhu-rider deleted the enable-session-expansion branch November 24, 2025 14:30
@roman-khimov roman-khimov modified the milestones: v0.51.0, v0.51.1 Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants