Skip to content

ir: do not log public keys in base64, use hex instead#3690

Merged
roman-khimov merged 1 commit intomasterfrom
fix/ir-base64-keys-in-logs
Nov 21, 2025
Merged

ir: do not log public keys in base64, use hex instead#3690
roman-khimov merged 1 commit intomasterfrom
fix/ir-base64-keys-in-logs

Conversation

@carpawell
Copy link
Member

No description provided.

@carpawell carpawell self-assigned this Nov 21, 2025
@carpawell carpawell force-pushed the fix/ir-base64-keys-in-logs branch from 2b0cdb0 to 65f47e7 Compare November 21, 2025 12:14
@carpawell carpawell marked this pull request as ready for review November 21, 2025 12:14
@carpawell carpawell force-pushed the fix/ir-base64-keys-in-logs branch 2 times, most recently from bbf5e79 to 09b5a6f Compare November 21, 2025 12:15
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell force-pushed the fix/ir-base64-keys-in-logs branch from 09b5a6f to 4e5cbd2 Compare November 21, 2025 12:16
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 27.34%. Comparing base (e129c34) to head (4e5cbd2).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/innerring/processors/container/handlers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3690      +/-   ##
==========================================
+ Coverage   27.33%   27.34%   +0.01%     
==========================================
  Files         658      658              
  Lines       41801    41801              
==========================================
+ Hits        11426    11431       +5     
+ Misses      29312    29309       -3     
+ Partials     1063     1061       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov roman-khimov merged commit a4005c9 into master Nov 21, 2025
18 of 19 checks passed
@roman-khimov roman-khimov deleted the fix/ir-base64-keys-in-logs branch November 21, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants