Skip to content

Incomplete PUT OID#3686

Merged
roman-khimov merged 2 commits intomasterfrom
incomplete-put-oid
Nov 20, 2025
Merged

Incomplete PUT OID#3686
roman-khimov merged 2 commits intomasterfrom
incomplete-put-oid

Conversation

@roman-khimov
Copy link
Member

@roman-khimov roman-khimov commented Nov 20, 2025

No description provided.

@roman-khimov
object: return oid directly from Close(), drop res wrapper
20a8b58 
Untangle the code a bit.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov added this to the v0.50.0 milestone Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.35%. Comparing base (da778da) to head (da861ab).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/object/delete/util.go 0.00% 1 Missing ⚠️
pkg/services/object/put/streamer.go 75.00% 1 Missing ⚠️
pkg/services/object/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3686      +/-   ##
==========================================
+ Coverage   27.34%   27.35%   +0.01%     
==========================================
  Files         658      657       -1     
  Lines       41713    41707       -6     
==========================================
+ Hits        11407    11410       +3     
+ Misses      29246    29238       -8     
+ Partials     1060     1059       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cthulhu-rider
cthulhu-rider reviewed Nov 20, 2025
View reviewed changes
@roman-khimov
Copy link
Member Author

roman-khimov commented Nov 20, 2025 •
edited
Loading

OK, something is still wrong here. Will check.
https://rest.fs.neo.org/Aku38wpn2xEqfEPxmwyAa7N3VnAkMV8PEVkpLqwKM1z3/4350-1763651993/index.html#suites/7c03b137b3ee28ef55fbaf774dbf0087/31c92ce145565209/
https://rest.fs.neo.org/Aku38wpn2xEqfEPxmwyAa7N3VnAkMV8PEVkpLqwKM1z3/4350-1763648718/index.html#suites/7c03b137b3ee28ef55fbaf774dbf0087/9376db5124427d0f/

@roman-khimov
object: don't lose oid in slicing target for ErrIncomplete
da861ab 
Fixes

    Error: rpc error: finish object stream: invalid ID field in the response: zero object ID

for two replicas in REP 3 container.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov
Copy link
Member Author

roman-khimov commented Nov 20, 2025

Fixed.

@roman-khimov roman-khimov merged commit 5e031f9 into master Nov 20, 2025
21 of 22 checks passed
@roman-khimov roman-khimov deleted the incomplete-put-oid branch November 20, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@End-rey End-rey End-rey approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.50.0

Development

Successfully merging this pull request may close these issues.

3 participants

@roman-khimov @cthulhu-rider @End-rey