Merged
Conversation
Fix "Error: rpc error: finish object stream: missing ID field in the response". Signed-off-by: Roman Khimov <roman@nspcc.ru>
It didn't happen and the error is final for this particular node, errIncomplete makes no sense here. This didn't matter much before Incomplete became a separate status, but now 0/1 is not the combo where it can be expected. Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's just an attribute in its essense and it is already known for unsealed
objects. Absent this check a node can save some object locally even if it's
expired if slicing is performed on the same node which subsequently leads to
test_put_of_already_expired_object reporting this:
Error: rpc error: finish object stream: status: code = 1 message = incomplete object PUT by placement: number of replicas cannot be met for list #0: 1 required, 0 nodes remaining (last node error: could not close object stream: replicate object to remote node (key=03abb3c3361f840477b1e80e2c55278b05067d1c7e362a6f30def3400bde6c5e9a): /dns4/localhost/tcp/41859: status: code = 1024 message = failed to verify and store object locally: validate object format: object did not pass expiration check: object has expired: attribute: 21, current: 22)
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3684 +/- ##
==========================================
- Coverage 27.34% 27.34% -0.01%
==========================================
Files 658 658
Lines 41712 41713 +1
==========================================
- Hits 11407 11406 -1
- Misses 29244 29245 +1
- Partials 1061 1062 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carpawell
approved these changes
Nov 20, 2025
cthulhu-rider
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.