Skip to content

object: fix panic on PUT error#3683

Merged
roman-khimov merged 1 commit intomasterfrom
fix-put-panic
Nov 19, 2025
Merged

object: fix panic on PUT error#3683
roman-khimov merged 1 commit intomasterfrom
fix-put-panic

Conversation

@roman-khimov
Copy link
Member

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xf81297]

goroutine 4070 [running]:
github.com/nspcc-dev/neofs-node/pkg/services/object.(*Server).sendPutResponse(0xc001ed62c0, {0x15d6090, 0xc0023788b0}, 0x0, {0x15bb0a0?, 0xc0003588c0?})
	github.com/nspcc-dev/neofs-node/pkg/services/object/server.go:236 +0x57
github.com/nspcc-dev/neofs-node/pkg/services/object.(*Server).Put(0xc001ed62c0, {0x15d6090, 0xc0023788b0})
	github.com/nspcc-dev/neofs-node/pkg/services/object/server.go:429 +0x6f0
github.com/nspcc-dev/neofs-sdk-go/proto/object._ObjectService_Put_Handler({0x132df80?, 0xc001ed62c0}, {0x15d0fa8, 0xc00137d590})
	github.com/nspcc-dev/neofs-sdk-go@v1.0.0-rc.16.0.20251118154818-9480da80f9ad/proto/object/service_grpc.pb.go:725 +0xd8
google.golang.org/grpc.(*Server).processStreamingRPC(0xc00153e000, {0x15cbdb0, 0xc001699080}, 0xc000b2ce40, 0xc001e606c0, 0x205c060, 0x0)
	google.golang.org/grpc@v1.75.1/server.go:1722 +0x12e8
google.golang.org/grpc.(*Server).handleStream(0xc00153e000, {0x15ccc30, 0xc000370340}, 0xc000b2ce40)
	google.golang.org/grpc@v1.75.1/server.go:1846 +0xb47
google.golang.org/grpc.(*Server).serveStreams.func2.1()
	google.golang.org/grpc@v1.75.1/server.go:1061 +0x7f
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 257
	google.golang.org/grpc@v1.75.1/server.go:1072 +0x11d

Regression of 85e0c6c.

    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xf81297]

    goroutine 4070 [running]:
    github.com/nspcc-dev/neofs-node/pkg/services/object.(*Server).sendPutResponse(0xc001ed62c0, {0x15d6090, 0xc0023788b0}, 0x0, {0x15bb0a0?, 0xc0003588c0?})
    	github.com/nspcc-dev/neofs-node/pkg/services/object/server.go:236 +0x57
    github.com/nspcc-dev/neofs-node/pkg/services/object.(*Server).Put(0xc001ed62c0, {0x15d6090, 0xc0023788b0})
    	github.com/nspcc-dev/neofs-node/pkg/services/object/server.go:429 +0x6f0
    github.com/nspcc-dev/neofs-sdk-go/proto/object._ObjectService_Put_Handler({0x132df80?, 0xc001ed62c0}, {0x15d0fa8, 0xc00137d590})
    	github.com/nspcc-dev/neofs-sdk-go@v1.0.0-rc.16.0.20251118154818-9480da80f9ad/proto/object/service_grpc.pb.go:725 +0xd8
    google.golang.org/grpc.(*Server).processStreamingRPC(0xc00153e000, {0x15cbdb0, 0xc001699080}, 0xc000b2ce40, 0xc001e606c0, 0x205c060, 0x0)
    	google.golang.org/grpc@v1.75.1/server.go:1722 +0x12e8
    google.golang.org/grpc.(*Server).handleStream(0xc00153e000, {0x15ccc30, 0xc000370340}, 0xc000b2ce40)
    	google.golang.org/grpc@v1.75.1/server.go:1846 +0xb47
    google.golang.org/grpc.(*Server).serveStreams.func2.1()
    	google.golang.org/grpc@v1.75.1/server.go:1061 +0x7f
    created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 257
    	google.golang.org/grpc@v1.75.1/server.go:1072 +0x11d

Regression of 85e0c6c.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov added bug Something isn't working U0 Needs to be resolved immediately labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.36%. Comparing base (a556ffc) to head (eedb9ef).

Files with missing lines Patch % Lines
pkg/services/object/server.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3683      +/-   ##
==========================================
+ Coverage   27.34%   27.36%   +0.01%     
==========================================
  Files         658      658              
  Lines       41715    41717       +2     
==========================================
+ Hits        11407    11414       +7     
+ Misses      29245    29243       -2     
+ Partials     1063     1060       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

1 similar comment
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.36%. Comparing base (a556ffc) to head (eedb9ef).

Files with missing lines Patch % Lines
pkg/services/object/server.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3683      +/-   ##
==========================================
+ Coverage   27.34%   27.36%   +0.01%     
==========================================
  Files         658      658              
  Lines       41715    41717       +2     
==========================================
+ Hits        11407    11414       +7     
+ Misses      29245    29243       -2     
+ Partials     1063     1060       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov roman-khimov merged commit 404d3d4 into master Nov 19, 2025
19 of 22 checks passed
@roman-khimov roman-khimov deleted the fix-put-panic branch November 19, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working U0 Needs to be resolved immediately

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants