*: use wallet scrypt params instead of default ones#3675
Merged
cthulhu-rider merged 1 commit intomasterfrom Nov 14, 2025
Merged
*: use wallet scrypt params instead of default ones#3675cthulhu-rider merged 1 commit intomasterfrom
cthulhu-rider merged 1 commit intomasterfrom
Conversation
Even though we're always using the same Scrypt parameters everywhere (except for some NeoGo internal tests), NEP-6 itself doesn't limit wallet in what scrypt settings they use, so the default ones might be wrong for some specific wallet and this can lead to decryption failure. Signed-off-by: Roman Khimov <roman@nspcc.ru>
ac39191 to
b1f3aef
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3675 +/- ##
=======================================
Coverage 27.39% 27.40%
=======================================
Files 658 658
Lines 41728 41728
=======================================
+ Hits 11431 11434 +3
+ Misses 29229 29227 -2
+ Partials 1068 1067 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
End-rey
approved these changes
Nov 14, 2025
cthulhu-rider
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though we're always using the same Scrypt parameters everywhere (except for some NeoGo internal tests), NEP-6 itself doesn't limit wallet in what scrypt settings they use, so the default ones might be wrong for some specific wallet and this can lead to decryption failure.