Skip to content

Support multi-level object nesting#3674

Merged
roman-khimov merged 4 commits intomasterfrom
bugfix/multi-level-parent-index
Nov 14, 2025
Merged

Support multi-level object nesting#3674
roman-khimov merged 4 commits intomasterfrom
bugfix/multi-level-parent-index

Conversation

@cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider commented Nov 13, 2025

defect was found in nspcc-dev/neofs-s3-gw#1235

Pointer was only used for nil comparison.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.37%. Comparing base (9959af2) to head (975d1c3).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/local_object_storage/metabase/metadata.go 78.94% 2 Missing and 2 partials ⚠️
pkg/local_object_storage/metabase/exists.go 88.88% 1 Missing ⚠️
pkg/local_object_storage/metabase/put.go 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3674      +/-   ##
==========================================
- Coverage   27.39%   27.37%   -0.03%     
==========================================
  Files         658      658              
  Lines       41728    41694      -34     
==========================================
- Hits        11431    11413      -18     
+ Misses      29229    29221       -8     
+ Partials     1068     1060       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthulhu-rider cthulhu-rider force-pushed the bugfix/multi-level-parent-index branch 4 times, most recently from ee8a73c to 0f07a81 Compare November 13, 2025 18:06
@cthulhu-rider cthulhu-rider marked this pull request as ready for review November 13, 2025 18:06
@cthulhu-rider cthulhu-rider force-pushed the bugfix/multi-level-parent-index branch from 0f07a81 to 4b01f13 Compare November 13, 2025 18:18
Previously, metabase did not index metadata for objects which are
parents of some parents. This was causing the search of root objects
with multi-level nesting to break. In particular, the restriction
affected split or S3 multipart in containers with EC.

Refs #3500. Refs nspcc-dev/neofs-s3-gw#1236.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This extends 3c62bde approach to nested
parents which are possible after 366e768.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
There are not so many of them.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider force-pushed the bugfix/multi-level-parent-index branch from 4b01f13 to 975d1c3 Compare November 13, 2025 20:10
@roman-khimov roman-khimov merged commit 058fe27 into master Nov 14, 2025
22 checks passed
@roman-khimov roman-khimov deleted the bugfix/multi-level-parent-index branch November 14, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants