pkg/timers: do not skip delta handlers ever#3668
Merged
cthulhu-rider merged 1 commit intomasterfrom Nov 6, 2025
Merged
Conversation
It was intended to prevent apps from making useless handler calls when they are outdated. Still, in practice, it introduced a race condition and skips events that must occur immediately at the new epoch event or near it. Treat every sub-epoch timer as not-called-yet at every `Reset` call; calling at the wrong time (when there is an incredible latency) is less error-prone than not calling at all. Closes #3652. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
d5860a7 to
d9ba602
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3668 +/- ##
==========================================
+ Coverage 27.37% 27.39% +0.01%
==========================================
Files 658 658
Lines 41762 41748 -14
==========================================
+ Hits 11433 11437 +4
+ Misses 29262 29246 -16
+ Partials 1067 1065 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Nov 5, 2025
cthulhu-rider
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was intended to prevent apps from making useless handler calls when they are
outdated. Still, in practice, it introduced a race condition and skips events
that must occur immediately at the new epoch event or near it. Treat every
sub-epoch timer as not-called-yet at every
Resetcall; calling at the wrongtime (when there is an incredible latency) is less error-prone than not calling
at all. Closes #3652.