Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3662 +/- ##
==========================================
+ Coverage 25.67% 25.69% +0.01%
==========================================
Files 660 660
Lines 42176 42167 -9
==========================================
+ Hits 10830 10833 +3
+ Misses 30362 30350 -12
Partials 984 984 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Jan 27, 2026
Member
|
Changelog? |
c40ae42 to
41f1a6e
Compare
carpawell
approved these changes
Jan 28, 2026
| func (s *Service) copyECObjectRangeByRule(ctx context.Context, dst ChunkWriter, localNodeKey ecdsa.PrivateKey, cnr cid.ID, | ||
| parent oid.ID, sTok *session.Object, rule iec.Rule, ruleIdx int, sortedNodes []netmap.NodeInfo, | ||
| off, ln uint64) (uint64, error) { | ||
| off, ln uint64) (uint64, uint64, error) { |
Member
There was a problem hiding this comment.
two same-typed return values now, comment?
When part of the range is processed, it is necessary to update not only the offset but also the length for the remainder. Refs #3423. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
41f1a6e to
3b63cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.