Skip to content

engine: fix split object stuck in GC cycle#3653

Merged
cthulhu-rider merged 1 commit intomasterfrom
3641-split-object-stuck-in-gc-cycle
Oct 30, 2025
Merged

engine: fix split object stuck in GC cycle#3653
cthulhu-rider merged 1 commit intomasterfrom
3641-split-object-stuck-in-gc-cycle

Conversation

@End-rey
Copy link
Contributor

@End-rey End-rey commented Oct 27, 2025

Closes #3641.

@End-rey End-rey self-assigned this Oct 27, 2025
@codecov
Copy link

codecov bot commented Oct 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.38%. Comparing base (3c2b016) to head (33d4969).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pkg/local_object_storage/engine/inhume.go 50.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3653      +/-   ##
==========================================
+ Coverage   27.36%   27.38%   +0.01%     
==========================================
  Files         656      656              
  Lines       41176    41178       +2     
==========================================
+ Hits        11268    11276       +8     
+ Misses      28851    28847       -4     
+ Partials     1057     1055       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cthulhu-rider
cthulhu-rider approved these changes Oct 28, 2025
View reviewed changes
@End-rey End-rey force-pushed the 3641-split-object-stuck-in-gc-cycle branch from 005da17 to 33d4969 Compare October 28, 2025 11:53
@End-rey
engine: fix split object stuck in GC cycle
33d4969 
In 4285097, a fallback option for a zero link has been added. Now, the
fallback option is also used when the link object is not zero but cannot be
found or read.

Closes #3641.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
@cthulhu-rider cthulhu-rider merged commit 8952e0a into master Oct 30, 2025
22 checks passed
@cthulhu-rider cthulhu-rider deleted the 3641-split-object-stuck-in-gc-cycle branch October 30, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

Assignees

@End-rey End-rey

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Split object stuck in GC cycle

2 participants

@End-rey @cthulhu-rider