engine: make more detailed removal of the split object#3633
Merged
roman-khimov merged 1 commit intomasterfrom Oct 15, 2025
Merged
engine: make more detailed removal of the split object#3633roman-khimov merged 1 commit intomasterfrom
roman-khimov merged 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3633 +/- ##
==========================================
+ Coverage 26.66% 26.72% +0.06%
==========================================
Files 653 653
Lines 50198 50254 +56
==========================================
+ Hits 13385 13431 +46
- Misses 35769 35779 +10
Partials 1044 1044 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
requested changes
Oct 13, 2025
ede81a7 to
f2676dd
Compare
Member
roman-khimov
left a comment
There was a problem hiding this comment.
Have you tried it on T4 metabase?
f2676dd to
2a91043
Compare
2a91043 to
72ed227
Compare
roman-khimov
approved these changes
Oct 15, 2025
72ed227 to
4285097
Compare
When processing and deleting a split object, if there is no linking object, we also check the first and split IDs, which allow getting information about other child objects. Closes #3629. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
cthulhu-rider
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3629.