Skip to content

Fix reporting errors#3631

Merged
roman-khimov merged 3 commits intomasterfrom
fix-reporting-errors
Oct 13, 2025
Merged

Fix reporting errors#3631
roman-khimov merged 3 commits intomasterfrom
fix-reporting-errors

Conversation

@roman-khimov
Copy link
Member

No description provided.

Fixes

    {"component": "containerReports", "epoch": 24604, "epoch": 24604, "epoch": 24604, "epoch": 24605, "epoch": 24605, "epoch": 24605, "epoch": 24606, "epoch": 24606, "epoch": 24606, "epoch": 24607, "epoch": 24607, "epoch": 24607, "epoch": 24608, "epoch": 24608, "epoch": 24608, "epoch": 24609, "epoch": 24609, "epoch": 24609, "epoch": 24610, "epoch": 24610, "epoch": 24610, "epoch": 24611, "epoch": 24611, "epoch": 24611, "epoch": 24612, "epoch": 24613, "cid": "E9X5uoYexPdRjGTwyrvuM2a1hFjoNdhQGJtBq4MUsmUt", "error": "could not invoke method (putReport): chain/client: contract execution finished with state FAULT; exception: at instruction 8316 (THROW): unhandled exception: "method must be invoked by storage node from container""}

Rename parameter to avoid shadowing and associated confusion.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Fixes #3625.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Placement policy application failure happens when:
 * it's broken
 * it can't work for current netmap (not enough nodes)

Usually this leads to reporting the same issue again and again each time
this container is touched which doesn't make a lot of sense when the only
thing we care about it whether we're a part of container node set.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.66%. Comparing base (d38cb71) to head (7908ee4).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-node/container.go 0.00% 14 Missing ⚠️
cmd/neofs-node/meta.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3631   +/-   ##
=======================================
  Coverage   26.65%   26.66%           
=======================================
  Files         653      653           
  Lines       50187    50198   +11     
=======================================
+ Hits        13379    13383    +4     
- Misses      35763    35771    +8     
+ Partials     1045     1044    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov roman-khimov merged commit 9bf1493 into master Oct 13, 2025
20 of 22 checks passed
@roman-khimov roman-khimov deleted the fix-reporting-errors branch October 13, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants