Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3594 +/- ##
==========================================
+ Coverage 26.65% 26.69% +0.03%
==========================================
Files 655 655
Lines 49700 49749 +49
==========================================
+ Hits 13249 13281 +32
- Misses 35408 35420 +12
- Partials 1043 1048 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b01f69f to
a62eabc
Compare
roman-khimov
approved these changes
Sep 24, 2025
Member
roman-khimov
left a comment
There was a problem hiding this comment.
We don't check for shard ID now, but probably the mechanism of IDs needs to be updated first, so at this stage it's all ok and solves the main problem we wanted to solve.
pkg/local_object_storage/blobstor/fstree/fstree_descriptor_test.go
Outdated
Show resolved
Hide resolved
pkg/local_object_storage/blobstor/fstree/fstree_descriptor_test.go
Outdated
Show resolved
Hide resolved
pkg/local_object_storage/blobstor/fstree/fstree_descriptor_test.go
Outdated
Show resolved
Hide resolved
pkg/local_object_storage/blobstor/fstree/fstree_descriptor_test.go
Outdated
Show resolved
Hide resolved
pkg/local_object_storage/blobstor/fstree/fstree_descriptor_test.go
Outdated
Show resolved
Hide resolved
0b5926e to
571807b
Compare
cthulhu-rider
approved these changes
Sep 25, 2025
571807b to
7ac59ad
Compare
7ac59ad to
bfb2b82
Compare
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Dynamic name length was never needed, and it's never changed. There are zero reasons to change it (unlike depth, for example). And it can't be changed by user currently, it's completely internal to the node. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Checks the layout parameters during initialization and, if the parameters have changed, returns an error so that the administrator can make changes. Closes #2174. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Use `t.TempDir`, which is automatically removed after the test and all its subtests are completed. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
carpawell
approved these changes
Sep 26, 2025
| if err != nil { | ||
| return fmt.Errorf("encode descriptor to JSON: %w", err) | ||
| } | ||
| tmp := descPath + ".tmp" |
Member
There was a problem hiding this comment.
why do we need it to be tmp and renamed then?
Member
There was a problem hiding this comment.
Avoid inconsistent state in case of sudden shutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2174.