Conversation
1c5a223 to
071a5f8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3556 +/- ##
==========================================
+ Coverage 24.93% 25.60% +0.67%
==========================================
Files 660 661 +1
Lines 49356 49446 +90
==========================================
+ Hits 12307 12663 +356
+ Misses 36059 35777 -282
- Partials 990 1006 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prevent data race conditions for tests run with `-race` flag. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
071a5f8 to
2811d4c
Compare
roman-khimov
left a comment
There was a problem hiding this comment.
Looks like tests are missing in fact.
End-rey
left a comment
There was a problem hiding this comment.
In the previous force-push, I found that the tests that should be here were deleted. Or is that how it should be?
2811d4c to
09753dd
Compare
|
fixed unadded files |
pkg/services/policer/policer_test.go
Outdated
| } | ||
| } | ||
| if expShortage > 0 { | ||
| require.Eventually(t, repTaskSubmitted, 300*time.Millisecond, 30*time.Millisecond) |
There was a problem hiding this comment.
300ms can be insufficient for busy GH runners.
There was a problem hiding this comment.
hmm, didn't think about it. How much u think to increase for better reliability?
There was a problem hiding this comment.
Something like 3s, shouldn't affect regular operation much, but should be sufficient to prevent false negatives as well.
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
09753dd to
f50ff81
Compare
No description provided.