Skip to content

CLI range file improvements#3544

Merged
cthulhu-rider merged 3 commits intomasterfrom
cli-range-file
Aug 26, 2025
Merged

CLI range file improvements#3544
cthulhu-rider merged 3 commits intomasterfrom
cli-range-file

Conversation

@cthulhu-rider
Copy link
Contributor

@cthulhu-rider cthulhu-rider commented Aug 26, 2025

No description provided.

@cthulhu-rider cthulhu-rider changed the title Cli range file CLI range file improvements Aug 26, 2025
@cthulhu-rider
cli/object: Truncate output file in range command
8bcebc4 
So the file will contain only the requested data. This is how `get`
command behaves.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@codecov
Copy link

codecov bot commented Aug 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.98%. Comparing base (be59b71) to head (2056867).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-cli/modules/object/util.go 0.00% 6 Missing ⚠️
cmd/neofs-cli/modules/object/get.go 0.00% 2 Missing ⚠️
cmd/neofs-cli/modules/object/range.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3544      +/-   ##
==========================================
- Coverage   24.98%   24.98%   -0.01%     
==========================================
  Files         677      677              
  Lines       50201    50207       +6     
==========================================
- Hits        12545    12544       -1     
- Misses      36663    36670       +7     
  Partials      993      993

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthulhu-rider cthulhu-rider marked this pull request as ready for review August 26, 2025 11:02
carpawell
carpawell approved these changes Aug 26, 2025
View reviewed changes
@cthulhu-rider
cli/object: Create output file with rw-r--r-- permissions
750d53d 
Replace `rwxrwxrwx`. This is how `get` command behaves.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
cli/object: Share file open code in get and range commands
2056867 
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider merged commit c3c4080 into master Aug 26, 2025
20 of 22 checks passed
@cthulhu-rider cthulhu-rider deleted the cli-range-file branch August 26, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carpawell carpawell carpawell approved these changes

@roman-khimov roman-khimov Awaiting requested review from roman-khimov roman-khimov is a code owner

@End-rey End-rey Awaiting requested review from End-rey End-rey is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cthulhu-rider @carpawell