Fix tomstoned objects revival not working#3542
Merged
roman-khimov merged 1 commit intomasterfrom Sep 3, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3542 +/- ##
==========================================
+ Coverage 24.93% 25.03% +0.10%
==========================================
Files 660 660
Lines 49356 49411 +55
==========================================
+ Hits 12307 12372 +65
+ Misses 36059 36042 -17
- Partials 990 997 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
cthulhu-rider
left a comment
There was a problem hiding this comment.
should work after the fix
Contributor
Author
|
@cthulhu-rider what if I delete a tombstone at the shard level, to also delete it from blobstor? Or do I need to just delete it from the metabase? Since we put tombstone, shouldn't the object be put in graveyard? |
Member
Metabase and storage should be in sync. |
ce13e97 to
cfb660f
Compare
Delete tombstone after revival. Note that deletion occurs only on the specific node where the object is located. Closes #3486. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
roman-khimov
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3486.
Now, if you revive an object on a specific node, then it can only be retrieved on it. It will still be unavailable on other nodes. And the tombstone object is physically deleted only if it was in that node. Is this the right logic?