Fix send on closed channel panic in epoch handler#3529
Merged
cthulhu-rider merged 1 commit intomasterfrom Aug 21, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3529 +/- ##
==========================================
+ Coverage 23.93% 24.87% +0.93%
==========================================
Files 669 675 +6
Lines 50251 50127 -124
==========================================
+ Hits 12028 12467 +439
+ Misses 37257 36667 -590
- Partials 966 993 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
87396af to
2faaa0c
Compare
Contributor
|
indeed, #3522 gonna replace these channels. But it is still better to have a fix. Besides, it is not difficult to make proposed solution just hides the cause to me. The current implementation is unsafe: the channel is written and closed concurrently. The easiest solution i see is dropping channel closure as not required. Alternatively, manage channels by engine and pass them to Shard read-only |
2faaa0c to
bbee211
Compare
cthulhu-rider
approved these changes
Aug 21, 2025
bbee211 to
ff7977f
Compare
Stop via stopChannel and keep eventChan open. Closes #3508. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
carpawell
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3508.
Is this enough or is it necessary to fix the problem in the node? It's just not very clear if there is a problem in the system.