Fix FSTree problems with extracting headers from combined objects#3518
Merged
cthulhu-rider merged 3 commits intomasterfrom Aug 14, 2025
Merged
Fix FSTree problems with extracting headers from combined objects#3518cthulhu-rider merged 3 commits intomasterfrom
cthulhu-rider merged 3 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3518 +/- ##
==========================================
+ Coverage 23.91% 23.93% +0.02%
==========================================
Files 669 669
Lines 50248 50251 +3
==========================================
+ Hits 12018 12030 +12
+ Misses 37261 37256 -5
+ Partials 969 965 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
24df51e to
3104460
Compare
09d1429 to
3b27632
Compare
Contributor
cthulhu-rider
left a comment
There was a problem hiding this comment.
resolve conflict pls
3b27632 to
0b7ed3a
Compare
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Due to the fact that the length of buffer did not correspond to the capacity and did not increase anywhere, there were cases when there were fewer bytes in the buffer than necessary. Fix problem. Add check for the length of slice in the parsing of the combined prefix. Add test. Closes #3517. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
If the ID was not found, then the program entered an endless loop. The EOF is now checked on a new buffer read. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
cthulhu-rider
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3517.