Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3511 +/- ##
=======================================
Coverage 23.58% 23.59%
=======================================
Files 669 669
Lines 50256 50278 +22
=======================================
+ Hits 11855 11864 +9
- Misses 37483 37493 +10
- Partials 918 921 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Each expired _shard_ object currently triggers engine-level operations. These are mostly relevant for split objects and are absolutely useless for tombstones because tombstones have no children and they can't be locked. Therefore TS-related operations can be local to shard, what we need to do is to drop them, so mark them garbage for now and let the other GC part handle it. I believe this is one of the things that triggered #3507 since we have a lot of deleted objects in some containers and iterating over TSes just takes time. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Fixes #3507 where an incomplete GC cycle blocks event handler which then breaks WS client which then can't be restarted because we're still handling an event. It's not a huge problem to miss this event if things are still moving, there will be a new one with a new epoch and it'll do the job anyway. Signed-off-by: Roman Khimov <roman@nspcc.ru>
87eb527 to
ceed724
Compare
cthulhu-rider
approved these changes
Aug 8, 2025
| return | ||
| } | ||
|
|
||
| err = s.MarkGarbage(false, expired...) |
Contributor
There was a problem hiding this comment.
looking at the added code I seem to remember that it was like that once. Except maybe through a callback to the entire engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.