Simplify API client code#3509

Merged

cthulhu-rider merged 29 commits intomasterfrom

object-get-refactor

Aug 18, 2025

Contributor

cthulhu-rider commented Aug 7, 2025

No description provided.

cthulhu-rider force-pushed the object-get-refactor branch from 2ea973b to 58e369d Compare

August 7, 2025 14:34

codecov bot commented Aug 7, 2025 •

edited

Loading

Codecov Report

❌ Patch coverage is 3.80623% with 278 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.51%. Comparing base (c6a9bed) to head (e246d2e).
⚠️ Report is 38 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/services/object/get/util.go	0.00%	73 Missing ⚠️
cmd/neofs-cli/modules/object/put.go	0.00%	38 Missing ⚠️
pkg/services/object/search/util.go	0.00%	22 Missing ⚠️
cmd/neofs-cli/modules/object/get.go	0.00%	18 Missing ⚠️
cmd/neofs-cli/modules/object/hash.go	0.00%	18 Missing ⚠️
cmd/neofs-cli/modules/object/util.go	0.00%	16 Missing ⚠️
pkg/services/object/put/remote.go	40.00%	12 Missing and 3 partials ⚠️
cmd/neofs-cli/modules/object/range.go	0.00%	12 Missing ⚠️
cmd/neofs-cli/modules/object/search.go	0.00%	12 Missing ⚠️
cmd/neofs-cli/modules/object/head.go	0.00%	8 Missing ⚠️
... and 17 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3509      +/-   ##
==========================================
+ Coverage   24.21%   24.51%   +0.30%     
==========================================
  Files         677      671       -6     
  Lines       50538    49912     -626     
==========================================
- Hits        12237    12236       -1     
+ Misses      37311    36683     -628     
- Partials      990      993       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cthulhu-rider force-pushed the object-get-refactor branch 2 times, most recently from 5df0953 to 28b18a8 Compare

August 7, 2025 14:39

cthulhu-rider marked this pull request as ready for review

August 7, 2025 14:56

cthulhu-rider requested review from End-rey, carpawell and roman-khimov as code owners

August 7, 2025 14:56

cthulhu-rider force-pushed the object-get-refactor branch from 28b18a8 to fc8455c Compare

August 11, 2025 07:58

carpawell approved these changes

View reviewed changes

Member

carpawell left a comment

Confilcts.

cmd/neofs-cli/internal/client/prm.go Outdated Show resolved Hide resolved

cthulhu-rider added 18 commits

August 18, 2025 14:06


          sn/object: Drop unused WithoutAssembly func

4ade7df

Drop assembly flag field as well, it's always true now.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          sn/object: Inline and drop internal HeadObject func

0fd5042

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          sn/object: Inline and drop internal PayloadRange func

97c7365

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          sn/object: Inline and drop internal GetObject func

956d883

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          sn/object: Inline and drop internal PutObject func

49aed33

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          sn/object: Inline and drop internal SearchObjects func

3a146a2

While `pkg/services/object/internal/client` package is emptied and
removed.

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          ir: Drop internal client package

5c00a7d

Unused since c552ed7.

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal BalanceOf func

6ca6c61

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal ListContainers func

f374659

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal GetContainer func

1f59acd

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal NetworkInfo func

ac5d031

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal NodeInfo func

74f646f

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal NetMapSnapshot func

bf05b1e

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal CreateSession func

0f765b1

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Refactor SessionPrm.SetClient method

f663611

In order to reduce the ties to internal things to be removed within
#2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Refactor session token setter in structured internal options

65f66ee

This will make it easier to abandon them within #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Refactor request metadata setters in structured internal options

8309b4a

This will make it easier to abandon them within #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal DeleteObject func

74a0c73

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>

cthulhu-rider force-pushed the object-get-refactor branch from fc8455c to dd2b419 Compare

August 18, 2025 11:07


          cli: Drop main-only flag of object head command

c9a6790

Closes #3065. Refs 60a25d5.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>

cthulhu-rider added 10 commits

August 18, 2025 14:10


          cli: Inline and drop internal HeadObject func

a44339a

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal SearchObjects func

429c99d

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal HashPayloadRanges func

f1acda1

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal PayloadRange func

ead7d18

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Refactor calling internal GetObject func

acff125

It's going to be removed within #2769. Since the function is complex,
this allows for more accurate refactoring.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal GetObject func

1ccab5a

Refs #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline internal PutObject func in object lock command

4879ee4

It's going to be removed within #2769. Since the function is complex,
this allows for more accurate refactoring.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Refactor calling internal PutObject func

7f62e62

It's going to be removed within #2769. Since the function is complex,
this allows for more accurate refactoring.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          cli: Inline and drop internal PutObject func

98121cb

Closes #2769.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>


          sn/object: Drop unused error

e246d2e

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>

cthulhu-rider force-pushed the object-get-refactor branch from dd2b419 to e246d2e Compare

August 18, 2025 11:11

cthulhu-rider merged commit 22f0daa into master

21 of 22 checks passed

cthulhu-rider deleted the object-get-refactor branch

August 18, 2025 13:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet