Prohibit locking tombstoned objects in storage#3495
Merged
roman-khimov merged 7 commits intomasterfrom Aug 5, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3495 +/- ##
==========================================
+ Coverage 23.46% 23.58% +0.12%
==========================================
Files 669 669
Lines 50243 50257 +14
==========================================
+ Hits 11788 11852 +64
+ Misses 37535 37486 -49
+ Partials 920 919 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
998dae3 to
925032b
Compare
roman-khimov
reviewed
Aug 1, 2025
43c2588 to
73b39fe
Compare
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Resync routine already ignores 'already removed' errors, therefore, the presence of both T and L in the BLOB storage will not stop the process: if L (T) object is written into metabase, T (L) is ignored. In the future, similar change will be made at higher levels, which will practically eliminate the possibility of having both L and T in single shard. Refs #3492. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Refs #3492. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Closes #3492. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Metabase may have lock mark for some object that is not stored. In this case, removal marking via tombstone associated with the object should be prohibited. Previously, it was not due to specific condition in target type check. This fixes type check to not prevent lock mark being handled. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
73b39fe to
1599ecb
Compare
roman-khimov
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.