Merged
Conversation
1s a lot of time for fast networks with dynamic blocks (50ms min). That's one of the reasons tests with dynamic blocks (nspcc-dev/neofs-testcases#1116) are running for ~same time as previously even though container operations became much faster to complete. Signed-off-by: Roman Khimov <roman@nspcc.ru>
This command uses protobuf directly, so it's harder to use network info there. At least use 1s time instead of 5s. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3488 +/- ##
==========================================
+ Coverage 23.43% 23.47% +0.04%
==========================================
Files 669 669
Lines 50312 50211 -101
==========================================
- Hits 11790 11787 -3
+ Misses 37601 37503 -98
Partials 921 921 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2a82835 to
33b2cf7
Compare
Contributor
cthulhu-rider
left a comment
There was a problem hiding this comment.
looks nice overall
Nothing useful in this code. Refs. #2769. Signed-off-by: Roman Khimov <roman@nspcc.ru>
No functional changes, refs. #2769. Signed-off-by: Roman Khimov <roman@nspcc.ru>
It does the same thing. I've tried to preserve output as much as possible, but this can't be done 100%. Signed-off-by: Roman Khimov <roman@nspcc.ru>
33b2cf7 to
987f109
Compare
cthulhu-rider
approved these changes
Jul 30, 2025
This was referenced Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.