Merged
Conversation
Continues b3e19e2. Other ops are going to be changed the same way in future commits. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Continues b3e19e2.. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Continues b3e19e2. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Continues b3e19e2. All these ops are very similar, so refactored in one scope. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Continues b3e19e2. This completes elimination of the recurrent architecture of object requests' handling. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
I have no idea what it means. We're operating in the original request context and it should be sufficient for now. Additional time-limited subcontexts can be created, but that's a different problem. If the upper layer exits this context ends up anyway. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3097 +/- ##
==========================================
+ Coverage 22.35% 22.49% +0.13%
==========================================
Files 763 752 -11
Lines 58645 58417 -228
==========================================
+ Hits 13110 13140 +30
+ Misses 44644 44385 -259
- Partials 891 892 +1 ☔ View full report in Codecov by Sentry. |
Merged
carpawell
approved these changes
Jan 30, 2025
Member
carpawell
left a comment
There was a problem hiding this comment.
Many many many many TODOs. But it seems to be in a working condition.
| if firstErr == nil { | ||
| firstErr = err | ||
| } | ||
| // TODO: log error |
|
|
||
| // Storage groups ops of the node's object storage required to serve NeoFS API | ||
| // Object service. | ||
| type sessions interface { |
Member
There was a problem hiding this comment.
do not see why it should be a separate private interface
Member
Author
There was a problem hiding this comment.
Yeah, not really needed, but we can't delay SDK much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last chunk from #3057. Less api-go overall, should be the same functionally.