node/objects: Distribute objects in container via replication protocol #2802
Merged
node/objects: Distribute objects in container via replication protocol #2802
Conversation
Contributor
cthulhu-rider
commented
Apr 5, 2024
- based on and blocked by engine: Support writing already encoded objects #2801 (first 2 commits)
9cc9710 to
7c7c108
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2802 +/- ##
==========================================
+ Coverage 23.61% 23.64% +0.02%
==========================================
Files 770 772 +2
Lines 44527 44651 +124
==========================================
+ Hits 10514 10556 +42
- Misses 33163 33241 +78
- Partials 850 854 +4 ☔ View full report in Codecov by Sentry. |
bc05110 to
97e6ffd
Compare
Member
|
post-0.41.0 |
97e6ffd to
041b24b
Compare
carpawell
reviewed
May 7, 2024
|
|
||
| // SendReplicationRequestToNode connects to described node and sends prepared | ||
| // replication request message to it. | ||
| func (x *transport) SendReplicationRequestToNode(ctx context.Context, req []byte, node coreclient.NodeInfo) error { |
Member
There was a problem hiding this comment.
shouldn't binary object be here as arg while request collection is placed inside this func?
Contributor
Author
There was a problem hiding this comment.
nope for the sake of performance: node sends same object to several nodes
041b24b to
af2a759
Compare
This was referenced Jun 27, 2024
Closed
Method can be used to send raw requests. Nothing prevents the implementation to be done. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Previously, storage nodes always sent "ready" objects after client data slicing via NeoFS API `ObjectService.Put` RPC. Recently, NeoFS protocol was extended with `ObjectService.Replicate` RPC allowing to replicate object from one container node to another. New RPC is more efficient, and now used by Policer+Replicator tandem to replicate objects on shortage. Actually, when `ObjectService.Put` server makes initial object save, it does completely the same. In total, when `Put` server represents storage node from the container, it can use `Replicate` RPC for better performance. An additional advantage is the one-time encoding of the protocol message, which is reused for sending to different nodes. This reduces the memory cost of processing each data stream. Refs #2316. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
af2a759 to
92a01fe
Compare
carpawell
approved these changes
Jul 4, 2024
Member
carpawell
left a comment
There was a problem hiding this comment.
I think, we need a deep refactor in the distribution code, it went through a lot of changes. We have many "dynamic" code (where []byte may mean different things, obj and encodedObject are neighbors fields, etc), traverser is not the only one who knows about object placement, some TODOs and proto code are also here but we need to go further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.