Add support to store/restore/delete binary objects#1924
Merged
fyrchik merged 1 commit intonspcc-dev:masterfrom Nov 1, 2022
Merged
Add support to store/restore/delete binary objects#1924fyrchik merged 1 commit intonspcc-dev:masterfrom
fyrchik merged 1 commit intonspcc-dev:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1924 +/- ##
==========================================
+ Coverage 30.42% 30.45% +0.03%
==========================================
Files 380 380
Lines 27777 27718 -59
==========================================
- Hits 8451 8442 -9
+ Misses 18630 18583 -47
+ Partials 696 693 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Do we declare merging behavior of the command? I mean if we provide filepath to serialized object, and specifiy, for example, attributes, they are set in the resulting object. If so, IMO this complicates the command. I would prefer to have indiviual commands for object formation and storing. |
carpawell
reviewed
Oct 21, 2022
carpawell
approved these changes
Oct 21, 2022
fyrchik
approved these changes
Nov 1, 2022
Contributor
|
Could you add |
…y objects Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1338
With flag
--binaryuser can point to the file with serialized object structure - id + signature + header + payloadAdded for development purposes.
Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com