Feat/Logical object counters#1771
Merged
cthulhu-rider merged 7 commits intonspcc-dev:masterfrom Sep 13, 2022
carpawell:feat/logical-object-counters
Merged
Feat/Logical object counters#1771cthulhu-rider merged 7 commits intonspcc-dev:masterfrom carpawell:feat/logical-object-counters
cthulhu-rider merged 7 commits intonspcc-dev:masterfrom
carpawell:feat/logical-object-counters
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
+ Coverage 33.38% 33.58% +0.19%
==========================================
Files 352 352
Lines 23499 23637 +138
==========================================
+ Hits 7845 7938 +93
- Misses 15004 15040 +36
- Partials 650 659 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fyrchik
reviewed
Sep 12, 2022
It will allow to use labeled object counters, e.g.: "phy" for all the physically stored objects, "logic" for only available objects. Also, it will allow to add typed (regular, TS, SG, LOCK) counters if needed. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
It now supports typed object counter metrics. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider
previously approved these changes
Sep 13, 2022
Do not treat objects with expiration as expired by default. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
- Meta now supports (and requires) inc/dec labeled counters - The new logic counter is incremented on `Put` operations and is decremented on `Inhume` and `Delete` operations that are performed on _stored_ objects only - Allow force counters sync. "Force" mode should be used on metabase resync and should not be used on a regular meta start Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider
previously approved these changes
Sep 13, 2022
Member
Author
|
Also, added tests on the shard level. |
Use meta's operation results to change the metrics. Support typed object counters. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Do not perform operations that produce unused results in `syncCounter`. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
fyrchik
approved these changes
Sep 13, 2022
cthulhu-rider
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1658.
Will add tests for high-level components. UPD: done.