Set container CORS attribute by smallhive · Pull Request #555 · nspcc-dev/neofs-contract

smallhive · 2025-11-27T09:06:08Z

Closes #548.

codecov · 2025-11-27T09:24:22Z

Codecov Report

❌ Patch coverage is 81.29496% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.10%. Comparing base (f2b1030) to head (ebdc1b7).
⚠️ Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
contracts/container/contract.go	81.15%	26 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   62.28%   63.10%   +0.82%     
==========================================
  Files          29       29              
  Lines        3068     3204     +136     
==========================================
+ Hits         1911     2022     +111     
- Misses       1151     1176      +25     
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

roman-khimov · 2025-11-28T10:09:28Z

Rebase, please

smallhive · 2025-11-28T10:12:00Z

Rebase, please

Rebaed

contracts/container/contract.go

carpawell · 2025-12-01T14:40:40Z

contracts/container/contract.go

+		panic(cst.NotFoundError)
+	}
+
+	common.CheckOwnerWitness(common.WalletToScriptHash(ownerID))


sometimes we allow the alphabet to be able to rewrite smth in the contracts (#526), can this be useful for this? @roman-khimov

It is useful, I've added alphabet witness check as well

suppose the key point is net cfg allowing Alphabet witness

neofs-contract/contracts/container/contract.go

Lines 1441 to 1447 in f2b1030

netmapContractAddr := storage.Get(ctx, netmapContractKey).(interop.Hash160)

vRaw := contract.Call(netmapContractAddr, "config", contract.ReadOnly, cst.AlphabetManagesQuotasKey)

if vRaw == nil || !vRaw.(bool) {

common.CheckOwnerWitness(userScriptHash)

} else {

common.CheckAlphabetWitness()

}

contracts/container/contract.go

cthulhu-rider · 2025-12-03T10:37:48Z

@smallhive seems good overall. I also need exactly this, but for LOCK attribute (#558). So, lets try to fasten this PR. The only meaningful topic i wanna resolve here is https://github.com/nspcc-dev/neofs-contract/pull/555/files#r2584311944

i can improve the rest on my own

smallhive · 2025-12-03T14:12:02Z

@smallhive seems good overall. I also need exactly this, but for LOCK attribute (#558). So, lets try to fasten this PR. The only meaningful topic i wanna resolve here is https://github.com/nspcc-dev/neofs-contract/pull/555/files#r2584311944

i can improve the rest on my own

I will add ResetAttribute function. Unfortunately, the link https://github.com/nspcc-dev/neofs-contract/pull/555/files#r2584311944 opens, but shows nothing. Resolve all conversations, except you would like to discuss

contracts/container/contract.go

tests/container_test.go

contracts/container/contract.go

Closes #548. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>

carpawell · 2025-12-05T11:41:54Z

tests/container_test.go

 )

+// CORSRule describes one rule for the container’s CORS attribute. It is the same as in contract.
+type CORSRule struct {


this can be used from rpc package now?

carpawell · 2025-12-05T11:43:41Z

rpc/container/model.go

+
+type (
+	// CORSRule describes one rule for the container’s CORS attribute.
+	CORSRule struct {


so it is only used as a json holder, right? i would add json: tags then, and a little bit more info to its doc

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from 6da3ec2 to 97cb1ed Compare November 27, 2025 09:15

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch 2 times, most recently from 7efa1af to 5750afa Compare November 28, 2025 06:21

smallhive marked this pull request as ready for review November 28, 2025 06:21

smallhive requested review from carpawell, cthulhu-rider and roman-khimov as code owners November 28, 2025 06:21

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from 5750afa to 67827a0 Compare November 28, 2025 10:11

carpawell reviewed Nov 28, 2025

View reviewed changes

contracts/container/contract.go Outdated Show resolved Hide resolved

cthulhu-rider requested changes Nov 28, 2025

View reviewed changes

contracts/container/contract.go Outdated Show resolved Hide resolved

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from 67827a0 to a840096 Compare December 1, 2025 10:26

smallhive requested a review from cthulhu-rider December 1, 2025 10:27

carpawell reviewed Dec 1, 2025

View reviewed changes

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from a840096 to 798d19b Compare December 1, 2025 15:23

smallhive requested a review from carpawell December 1, 2025 15:25

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch 2 times, most recently from 56c0e83 to 4984502 Compare December 2, 2025 10:06

cthulhu-rider reviewed Dec 3, 2025

View reviewed changes

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from 4984502 to f659262 Compare December 3, 2025 12:21

cthulhu-rider reviewed Dec 3, 2025

View reviewed changes

cthulhu-rider mentioned this pull request Dec 3, 2025

Support container deletion lock #558

Merged

cthulhu-rider reviewed Dec 3, 2025

View reviewed changes

contracts/container/contract.go Outdated Show resolved Hide resolved

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from 7e02653 to 70df532 Compare December 4, 2025 05:49

smallhive requested a review from cthulhu-rider December 4, 2025 05:50

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from 70df532 to 35c5fcd Compare December 4, 2025 06:10

cthulhu-rider reviewed Dec 4, 2025

View reviewed changes

contracts/container/contract.go Outdated Show resolved Hide resolved

contracts/container/contract.go Outdated Show resolved Hide resolved

contracts/container/contract.go Outdated Show resolved Hide resolved

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from 2e481a7 to 4f52d50 Compare December 4, 2025 08:22

smallhive requested a review from cthulhu-rider December 4, 2025 08:24

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch 2 times, most recently from ce2ad8f to 77a987e Compare December 4, 2025 10:54

cthulhu-rider previously approved these changes Dec 4, 2025

View reviewed changes

smallhive dismissed cthulhu-rider’s stale review via 3032e5d December 4, 2025 11:18

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch 2 times, most recently from 3032e5d to 5baba65 Compare December 4, 2025 11:25

cthulhu-rider previously approved these changes Dec 4, 2025

View reviewed changes

roman-khimov reviewed Dec 4, 2025

View reviewed changes

contracts/container/contract.go Outdated Show resolved Hide resolved

contracts/container/contract.go Outdated Show resolved Hide resolved

smallhive dismissed cthulhu-rider’s stale review via 9688073 December 5, 2025 06:07

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from 5baba65 to 9688073 Compare December 5, 2025 06:07

roman-khimov reviewed Dec 5, 2025

View reviewed changes

tests/container_test.go Outdated Show resolved Hide resolved

tests/container_test.go Outdated Show resolved Hide resolved

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch 2 times, most recently from 135c241 to a37d658 Compare December 5, 2025 07:52

cthulhu-rider reviewed Dec 5, 2025

View reviewed changes

contracts/container/contract.go Outdated Show resolved Hide resolved

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from a37d658 to 65a49f6 Compare December 5, 2025 08:39

smallhive added 2 commits December 5, 2025 13:18

container: Set CORS attribute

b934f5e

Closes #548. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>

linter: Fix Error return value is not checked

ebdc1b7

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>

smallhive force-pushed the 548-provide-a-method-to-update-well-known-cors-attribute branch from 65a49f6 to ebdc1b7 Compare December 5, 2025 09:18

roman-khimov approved these changes Dec 5, 2025

View reviewed changes

cthulhu-rider approved these changes Dec 5, 2025

View reviewed changes

carpawell approved these changes Dec 5, 2025

View reviewed changes

cthulhu-rider merged commit e3afe03 into master Dec 5, 2025
10 checks passed

cthulhu-rider deleted the 548-provide-a-method-to-update-well-known-cors-attribute branch December 5, 2025 13:08

roman-khimov mentioned this pull request Dec 8, 2025

SetAttribute container API nspcc-dev/neofs-api#360

Closed

	netmapContractAddr := storage.Get(ctx, netmapContractKey).(interop.Hash160)
	vRaw := contract.Call(netmapContractAddr, "config", contract.ReadOnly, cst.AlphabetManagesQuotasKey)
	if vRaw == nil \|\| !vRaw.(bool) {
	common.CheckOwnerWitness(userScriptHash)
	} else {
	common.CheckAlphabetWitness()
	}

Conversation

smallhive commented Nov 27, 2025

Uh oh!

codecov bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

roman-khimov commented Nov 28, 2025

Uh oh!

smallhive commented Nov 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carpawell Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

smallhive Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

cthulhu-rider Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

smallhive Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cthulhu-rider commented Dec 3, 2025

Uh oh!

smallhive commented Dec 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

carpawell Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

carpawell Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Nov 27, 2025 •

edited

Loading