Skip to content

Fix/meta object submitting by proxy#519

Merged
roman-khimov merged 2 commits intomasterfrom
fix/meta-object-submittion-by-proxy
Sep 23, 2025
Merged

Fix/meta object submitting by proxy#519
roman-khimov merged 2 commits intomasterfrom
fix/meta-object-submittion-by-proxy

Conversation

@carpawell
Copy link
Member

No description provided.

@carpawell carpawell self-assigned this Sep 22, 2025
Not an important change but still better be this way.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell force-pushed the fix/meta-object-submittion-by-proxy branch from 4e5a7b5 to f97a53d Compare September 22, 2025 19:53
@carpawell carpawell requested a review from End-rey September 22, 2025 19:55
@carpawell carpawell force-pushed the fix/meta-object-submittion-by-proxy branch 2 times, most recently from 9004ba1 to 814d4d0 Compare September 22, 2025 20:05
@carpawell carpawell marked this pull request as ready for review September 22, 2025 20:06
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 17.85714% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.98%. Comparing base (50f4c2c) to head (04d822f).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
contracts/proxy/contract.go 16.36% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   62.50%   61.98%   -0.53%     
==========================================
  Files          24       24              
  Lines        3470     3504      +34     
==========================================
+ Hits         2169     2172       +3     
- Misses       1301     1332      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

roman-khimov
roman-khimov previously approved these changes Sep 23, 2025
Neo VM allows misusing array method types, Container's `SubmitObjectPut` must
only support `[][]interop.Signature` as signatures array, not a flat array of
signatures according to NeoFS's placement policies.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@roman-khimov roman-khimov merged commit 54ca3b9 into master Sep 23, 2025
8 of 10 checks passed
@roman-khimov roman-khimov deleted the fix/meta-object-submittion-by-proxy branch September 23, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants