container: add container placement verification#440
Merged
roman-khimov merged 1 commit intomasterfrom Oct 16, 2024
Merged
Conversation
a9edb96 to
0cc2e70
Compare
Member
Author
|
Not the most optimal implementation but good enough for now. Not sure if it should have |
Member
roman-khimov
left a comment
There was a problem hiding this comment.
Looks legit for unordered signatures.
0cc2e70 to
db11d32
Compare
db11d32 to
a3fae3b
Compare
carpawell
commented
Oct 16, 2024
The new `VerifyPlacementSignatures` checks if a message was signed by a suitable number of nodes. Number is taken from the contract storage, their relevance should be ensured and maintained by the Alphabet nodes every epoch. Closes #413. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
a3fae3b to
d5e22de
Compare
roman-khimov
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
VerifyPlacementSignatureschecks if a message was signed by a suitable number of nodes. Number is taken from the contract storage, their relevance should be ensured and maintained by the Alphabet nodes every epoch. Closes #413.