rpc: allow to getcontractstate by id or name#1426
Merged
roman-khimov merged 5 commits intomasterfrom Nov 5, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1426 +/- ##
==========================================
+ Coverage 77.46% 77.55% +0.08%
==========================================
Files 229 229
Lines 17801 17869 +68
==========================================
+ Hits 13790 13858 +68
+ Misses 3056 3046 -10
- Partials 955 965 +10
Continue to review full report at Codecov.
|
19178cc to
10304ef
Compare
3235fb5 to
7fefa9a
Compare
roman-khimov
requested changes
Nov 2, 2020
Member
roman-khimov
left a comment
There was a problem hiding this comment.
We also need to document our protocol extensions.
ad6fe5e to
3ef9383
Compare
roman-khimov
requested changes
Nov 3, 2020
... for `invokefunction` RPC method.
... for getcontractstate RPC client method.
3ef9383 to
c07c54b
Compare
roman-khimov
reviewed
Nov 3, 2020
Member
roman-khimov
left a comment
There was a problem hiding this comment.
Yeah, it's all fine except for verify which should be moved out of this PR (and then developed in sync with C# codebase).
c07c54b to
fc018af
Compare
roman-khimov
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1423