Fix #140 (improve error messages)#142
Merged
kevaundray merged 1 commit intonspcc-dev:masterfrom Feb 20, 2019
Merged
Conversation
Contributor
im-kulikov
commented
Feb 19, 2019
- return errors like in C# code (Fix neo-project/neo-cli#297 neo-project/neo#587)
- update tests
- small refactoring
- return errors like in C# code (neo-project/neo#587) - update tests - small refactoring
Contributor
Author
|
@decentralisedkev / @fabwa any thoughts? |
fyrchik
approved these changes
Feb 20, 2019
Contributor
fyrchik
left a comment
There was a problem hiding this comment.
I have noticed, that assert.Equal is used for comparing json's. assert.JSONEq seems more suitable here to me. Could you change it?
Contributor
Author
I think it would be better to do it in a separate PR, don't you think? |
Contributor
Author
|
I add issue for your proposal #155 |
Contributor
|
Award im-kulikov 150 points |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.