Selective resolution; resolves #33 and #38. #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ea4fc0 to
b55cd87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to avoid resolving unused values.
Consider the following example:
Previously, even if the
GREETINGvariable was set (i.e..envfallback not used), thewhoamicommand would be run in a child process.After this change, the
whoamicommand will no longer be run ifGREETINGis already set in the environment.From this perspective, this PR resolves #38.
In addition, a long-standing issue has been that the return value of
loadFile/loadContentsis pretty meaningless and not useful. To eliminate any possible confusion, I have changed the return values toAff Unit, following stackbuilders/dotenv-hs#152.Therefore, this also resolves #33.