Skip to content

fix(core): handle external node without default version when generating a pnpm pruned lockfile#31503

Merged
FrozenPandaz merged 1 commit intomasterfrom
core/fix-semver-specifier-pnpm-parser
Jun 9, 2025
Merged

fix(core): handle external node without default version when generating a pnpm pruned lockfile#31503
FrozenPandaz merged 1 commit intomasterfrom
core/fix-semver-specifier-pnpm-parser

Conversation

@leosvelperez
Copy link
Copy Markdown
Member

Current Behavior

When generating a pruned pnpm lockfile, if there's no external node with a default version for a given package and the dependency specification for the package includes a Semver range specifier, an error is thrown.

Expected Behavior

When generating a pruned pnpm lockfile, the parser should correctly handle the scenario where there's no external node with a default version for a given package, and the dependency specification for the package includes a Semver range specifier.

Related Issue(s)

Fixes #28627

@leosvelperez leosvelperez self-assigned this Jun 9, 2025
@leosvelperez leosvelperez requested review from a team and meeroslav as code owners June 9, 2025 11:20
@leosvelperez leosvelperez requested a review from FrozenPandaz June 9, 2025 11:20
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jun 9, 2025 11:31am

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Jun 9, 2025

View your CI Pipeline Execution ↗ for commit 02d82e2.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 31m 26s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 3s View ↗
nx documentation ✅ Succeeded 1m 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-09 12:01:02 UTC

@FrozenPandaz FrozenPandaz merged commit e68d884 into master Jun 9, 2025
8 checks passed
@FrozenPandaz FrozenPandaz deleted the core/fix-semver-specifier-pnpm-parser branch June 9, 2025 13:31
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pruned lockfile generation with ^version's

2 participants