Skip to content

fix: add changelog shortcut to the keyboard shortcuts menu#2873

Merged
ghostdevv merged 5 commits into
npmx-dev:mainfrom
BittuBarnwal7479:search-help/add-changelog-shortcut
Jul 4, 2026
Merged

fix: add changelog shortcut to the keyboard shortcuts menu#2873
ghostdevv merged 5 commits into
npmx-dev:mainfrom
BittuBarnwal7479:search-help/add-changelog-shortcut

Conversation

@BittuBarnwal7479

@BittuBarnwal7479 BittuBarnwal7479 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

#2871

🧭 Context

The - shortcut for opening the changelog tab on package is shown in the UI but missing from the Keyboard Shortcuts search section.

📚 Description

The package page shows a - keyboard shortcut for opening the changelog, but this shortcut is not listed on the Keyboard shortcuts search section.

@vercel

vercel Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jul 4, 2026 3:09am
npmx.dev Ready Ready Preview, Comment Jul 4, 2026 3:09am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Jul 4, 2026 3:09am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds a new keyboard shortcut entry for opening the changelog. The AppFooter.vue shortcuts modal gains a - key row, the i18n schema defines a new shortcuts.section.changelog property, and translation strings are added in Arabic, English, Hindi, and Dutch locale files.

Changes

Changelog keyboard shortcut

Layer / File(s) Summary
i18n schema definition
i18n/schema.json
Adds a changelog string property under shortcuts.section in the schema.
AppFooter UI component
app/components/AppFooter.vue
Adds a new <li> entry rendering - as the key and $t('shortcuts.changelog') as the label in the shortcuts modal.
Locale translations
i18n/locales/ar.json, i18n/locales/en.json, i18n/locales/hi-IN.json, i18n/locales/nl.json
Adds the changelog shortcut translation string in each locale file.

Possibly related PRs

Suggested reviewers: ghostdevv

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: adding the changelog shortcut to the keyboard shortcuts menu.
Description check ✅ Passed The description is directly related to the change and explains the missing changelog shortcut in the UI.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/ar.json Localization changed, will be marked as complete. 🔄️
i18n/locales/en.json Source changed, localizations will be marked as outdated.
i18n/locales/hi-IN.json Localization changed, will be marked as complete. 🔄️
i18n/locales/nl.json Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you used AI to do the translations? Usually we prefer it if you only translate the languages you're familiar with as it's easier for people to add missing translations and fix broken ones (plus gives others a good way to contribute). Otherwise LGTM

@ghostdevv ghostdevv changed the title feat: add Missing "Open changelog" shortcut in Keyboard Shortcuts search section fix: add missing changelog entry in keyboard shortcuts menu Jun 7, 2026
@BittuBarnwal7479

Copy link
Copy Markdown
Contributor Author

I assume you used AI to do the translations? Usually we prefer it if you only translate the languages you're familiar with as it's easier for people to add missing translations and fix broken ones (plus gives others a good way to contribute). Otherwise LGTM

Yes, I used AI to help with the translations. The change was very small, just replacing a few English text.

I agree that native speakers are best suited for translation work, and I appreciate you pointing it out. I'll keep that in mind for future translation contributions.
Thanks!

@WilcoSp WilcoSp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but like what ghostdev said about the translations, at least in Dutch I localise it differently

Comment thread i18n/locales/nl.json Outdated
"settings": "Open instellingen",
"compare": "Open vergelijken",
"compare_from_package": "Vergelijking openen (vooraf ingevuld met het huidige pakket)",
"changelog": "Open changelog",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Dutch this should be "Open wijzigingenoverzicht"

Also for languages you don't know I would suggest leaving them empty instead of "{open} changelog" as it can be that some languages will localise it differently compared to translating directly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I agree, I'll keep that in mind for future translation contributions.

@WilcoSp WilcoSp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least for Dutch looking good now, further reviewing I'll leave up to ghostdevv.

I'll also share this pr in the i18n channel in discord, maybe some from there will look at the translations

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@i18n/locales/cs-CZ.json`:
- Line 39: The cs-CZ translation for the "changelog" key is misleading ("Otevřít
změny nového balíčku"); update the value for the "changelog" entry in
i18n/locales/cs-CZ.json (key: "changelog") to a neutral phrase that reflects
opening the changelog for the current package, e.g., "Otevřít changelog" or
"Otevřít změny balíčku", ensuring it no longer implies the package is new.

In `@i18n/locales/zh-TW.json`:
- Line 39: The "changelog" translation value currently reads "開啟變更日誌(針對新套件)",
which implies the shortcut is only for new packages; update the value for the
"changelog" key to remove the misleading qualifier and use "開啟變更日誌" so it
correctly reflects opening the changelog for the current package; locate the
"changelog" key in i18n/locales/zh-TW.json and replace its value accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e56b936e-6688-486f-ac4c-b92f6f747ff2

📥 Commits

Reviewing files that changed from the base of the PR and between 5ff06e6 and 710e3a6.

📒 Files selected for processing (9)
  • i18n/locales/cs-CZ.json
  • i18n/locales/hu-HU.json
  • i18n/locales/it-IT.json
  • i18n/locales/ja-JP.json
  • i18n/locales/pl-PL.json
  • i18n/locales/ta-IN.json
  • i18n/locales/tr-TR.json
  • i18n/locales/zh-CN.json
  • i18n/locales/zh-TW.json
✅ Files skipped from review due to trivial changes (5)
  • i18n/locales/zh-CN.json
  • i18n/locales/hu-HU.json
  • i18n/locales/pl-PL.json
  • i18n/locales/tr-TR.json
  • i18n/locales/ja-JP.json
🚧 Files skipped from review as they are similar to previous changes (2)
  • i18n/locales/ta-IN.json
  • i18n/locales/it-IT.json

Comment thread i18n/locales/cs-CZ.json Outdated
Comment thread i18n/locales/zh-TW.json Outdated

@gameroman gameroman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend to not adding translations for the languages you are not familiar with and wait until someone who does adds them later

@BittuBarnwal7479

Copy link
Copy Markdown
Contributor Author

I'd recommend to not adding translations for the languages you are not familiar with and wait until someone who does adds them later

I've removed the unverified translations and kept the change focused on the original fix.

@ghostdevv ghostdevv requested a review from gameroman June 16, 2026 23:53
@ghostdevv ghostdevv changed the title fix: add missing changelog entry in keyboard shortcuts menu fix: add changelog shortcut to the keyboard shortcuts menu Jul 4, 2026
@ghostdevv ghostdevv enabled auto-merge July 4, 2026 03:07
@ghostdevv ghostdevv added this pull request to the merge queue Jul 4, 2026
Merged via the queue into npmx-dev:main with commit fb67ebb Jul 4, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants