Skip to content

fix: remove the contributors only warning for connector#1920

Merged
danielroe merged 3 commits intonpmx-dev:mainfrom
liangmiQwQ:feat/remove-the-contributors-only-warn
Mar 4, 2026
Merged

fix: remove the contributors only warning for connector#1920
danielroe merged 3 commits intonpmx-dev:mainfrom
liangmiQwQ:feat/remove-the-contributors-only-warn

Conversation

@liangmiQwQ
Copy link
Contributor

🔗 Linked issue

Close #1778
(I'm not sure whether what the issue describe is the same thing as this pr)

🧭 Context

npmx-connector is now available on npm now
Screenshot 2026-03-04 at 20 22 13

📚 Description

This PR removed the warning and finished a todo added in #540. There are some modifies to ManagerSelect.vue to avoid content overlapping in a modal dialog.

image

@vercel
Copy link

vercel bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 4, 2026 0:27am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 4, 2026 0:27am
npmx-lunaria Ignored Ignored Mar 4, 2026 0:27am

Request Review

@liangmiQwQ liangmiQwQ changed the title feat: remove the contributors only warn feat: remove the contributors only warning Mar 4, 2026
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/ar.json Localization changed, will be marked as complete.
i18n/locales/az-AZ.json Localization changed, will be marked as complete.
i18n/locales/bg-BG.json Localization changed, will be marked as complete.
i18n/locales/bn-IN.json Localization changed, will be marked as complete.
i18n/locales/cs-CZ.json Localization changed, will be marked as complete.
i18n/locales/de-DE.json Localization changed, will be marked as complete.
i18n/locales/en.json Source changed, localizations will be marked as outdated.
i18n/locales/es.json Localization changed, will be marked as complete.
i18n/locales/fr-FR.json Localization changed, will be marked as complete.
i18n/locales/hi-IN.json Localization changed, will be marked as complete.
i18n/locales/hu-HU.json Localization changed, will be marked as complete.
i18n/locales/id-ID.json Localization changed, will be marked as complete.
i18n/locales/it-IT.json Localization changed, will be marked as complete.
i18n/locales/ja-JP.json Localization changed, will be marked as complete.
i18n/locales/kn-IN.json Localization changed, will be marked as complete.
i18n/locales/nb-NO.json Localization changed, will be marked as complete.
i18n/locales/ne-NP.json Localization changed, will be marked as complete.
i18n/locales/pl-PL.json Localization changed, will be marked as complete.
i18n/locales/pt-BR.json Localization changed, will be marked as complete.
i18n/locales/ru-RU.json Localization changed, will be marked as complete.
i18n/locales/ta-IN.json Localization changed, will be marked as complete.
i18n/locales/te-IN.json Localization changed, will be marked as complete.
i18n/locales/tr-TR.json Localization changed, will be marked as complete.
i18n/locales/uk-UA.json Localization changed, will be marked as complete.
i18n/locales/zh-CN.json Localization changed, will be marked as complete.
i18n/locales/zh-TW.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Header/ConnectorModal.vue 44.44% 4 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@danielroe danielroe changed the title feat: remove the contributors only warning fix: remove the contributors only warning Mar 4, 2026
@danielroe danielroe changed the title fix: remove the contributors only warning fix: remove the contributors only warning for connector Mar 4, 2026
@danielroe danielroe added this pull request to the merge queue Mar 4, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

📝 Walkthrough

Walkthrough

The pull request refactors the Local Connector modal component to support multiple package managers via a PackageManagerSelect component, replacing static command display logic with dynamic command generation based on the selected package manager. It removes all contributor-related user interface elements (badge, notice, and link) from the codebase by deleting the corresponding translation keys across 22 locale files and updating the i18n schema. The PackageManagerSelect component is enhanced with a teleport prop to conditionally disable Teleport functionality, enabling in-place dropdown rendering.

Possibly related PRs

Suggested reviewers

  • danielroe
  • graphieros
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description is related to the changeset. It mentions removing a contributors-only warning and modifying ManagerSelect.vue to avoid content overlapping in a modal dialog, which aligns with the code changes shown in the raw summary.
Linked Issues check ✅ Passed The PR successfully implements the feature requirements from issue #1778: adapts the local connector command to support different package managers (npm, pnpm, yarn, bun, deno, vlt) with a package manager selector component, and completes the todo from PR #540 by removing the contributors-only warning.
Out of Scope Changes check ✅ Passed All changes are within scope of the linked issue #1778. The PR modifies the ConnectorModal component to display dynamic package manager commands, adds a teleport prop to ManagerSelect to prevent dropdown overlapping, and removes contributor-related i18n keys and schema properties as part of the warning removal.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
app/components/Header/ConnectorModal.vue (2)

104-109: Redundant ms-auto class.

The ms-auto on the ButtonBase (line 107) is redundant since the parent <div> already has ms-auto and uses flex with gap-2. The button is already positioned correctly without it.

♻️ Suggested fix
           <ButtonBase
             :aria-label="copied ? $t('connector.modal.copied') : $t('connector.modal.copy_command')"
             `@click`="copyCommand"
-            class="ms-auto"
             :classicon="copied ? 'i-lucide:check text-green-500' : 'i-lucide:copy'"
           />

30-36: Await the copy() call and consider using the DEFAULT_PORT constant.

Two observations:

  1. Per the established pattern in useInstallCommand.ts (line 86), the copy() function returns a Promise that should be awaited. This ensures clipboard errors are not silently ignored.

  2. The port value '31415' is hard-coded on lines 8, 22, and 32, whilst DEFAULT_PORT is defined in app/composables/useConnector.ts (line 57). However, this constant is not currently exported, so you would need to export it from that file first before using it here.

♻️ Suggested refactor
-function copyCommand() {
+async function copyCommand() {
   let command = executeNpmxConnectorCommand.value
   if (portInput.value !== '31415') {
     command += ` --port ${portInput.value}`
   }
-  copy(command)
+  await copy(command)
 }

To also use DEFAULT_PORT, you would additionally need to export it from useConnector.ts and import it here, then replace the hard-coded '31415' with String(DEFAULT_PORT).


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bc1980bc-d570-4da5-8e72-b7cd49526ace

📥 Commits

Reviewing files that changed from the base of the PR and between 9c5a6cb and 8e160f4.

📒 Files selected for processing (29)
  • app/components/Header/ConnectorModal.vue
  • app/components/Package/ManagerSelect.vue
  • i18n/locales/ar.json
  • i18n/locales/az-AZ.json
  • i18n/locales/bg-BG.json
  • i18n/locales/bn-IN.json
  • i18n/locales/cs-CZ.json
  • i18n/locales/de-DE.json
  • i18n/locales/en.json
  • i18n/locales/es.json
  • i18n/locales/fr-FR.json
  • i18n/locales/hi-IN.json
  • i18n/locales/hu-HU.json
  • i18n/locales/id-ID.json
  • i18n/locales/it-IT.json
  • i18n/locales/ja-JP.json
  • i18n/locales/kn-IN.json
  • i18n/locales/nb-NO.json
  • i18n/locales/ne-NP.json
  • i18n/locales/pl-PL.json
  • i18n/locales/pt-BR.json
  • i18n/locales/ru-RU.json
  • i18n/locales/ta-IN.json
  • i18n/locales/te-IN.json
  • i18n/locales/tr-TR.json
  • i18n/locales/uk-UA.json
  • i18n/locales/zh-CN.json
  • i18n/locales/zh-TW.json
  • i18n/schema.json
💤 Files with no reviewable changes (27)
  • i18n/locales/az-AZ.json
  • i18n/locales/zh-TW.json
  • i18n/locales/id-ID.json
  • i18n/locales/bn-IN.json
  • i18n/locales/hi-IN.json
  • i18n/locales/te-IN.json
  • i18n/locales/bg-BG.json
  • i18n/locales/ja-JP.json
  • i18n/locales/cs-CZ.json
  • i18n/locales/en.json
  • i18n/locales/es.json
  • i18n/schema.json
  • i18n/locales/zh-CN.json
  • i18n/locales/ar.json
  • i18n/locales/tr-TR.json
  • i18n/locales/nb-NO.json
  • i18n/locales/pl-PL.json
  • i18n/locales/ta-IN.json
  • i18n/locales/de-DE.json
  • i18n/locales/kn-IN.json
  • i18n/locales/pt-BR.json
  • i18n/locales/ne-NP.json
  • i18n/locales/it-IT.json
  • i18n/locales/uk-UA.json
  • i18n/locales/fr-FR.json
  • i18n/locales/hu-HU.json
  • i18n/locales/ru-RU.json

Merged via the queue into npmx-dev:main with commit 6a44d71 Mar 4, 2026
23 checks passed
@liangmiQwQ liangmiQwQ deleted the feat/remove-the-contributors-only-warn branch March 4, 2026 12:34
@github-actions github-actions bot mentioned this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

local connector command package managers

2 participants