fix: remove the contributors only warning for connector#1920
fix: remove the contributors only warning for connector#1920danielroe merged 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe pull request refactors the Local Connector modal component to support multiple package managers via a PackageManagerSelect component, replacing static command display logic with dynamic command generation based on the selected package manager. It removes all contributor-related user interface elements (badge, notice, and link) from the codebase by deleting the corresponding translation keys across 22 locale files and updating the i18n schema. The PackageManagerSelect component is enhanced with a teleport prop to conditionally disable Teleport functionality, enabling in-place dropdown rendering. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
app/components/Header/ConnectorModal.vue (2)
104-109: Redundantms-autoclass.The
ms-autoon theButtonBase(line 107) is redundant since the parent<div>already hasms-autoand usesflexwithgap-2. The button is already positioned correctly without it.♻️ Suggested fix
<ButtonBase :aria-label="copied ? $t('connector.modal.copied') : $t('connector.modal.copy_command')" `@click`="copyCommand" - class="ms-auto" :classicon="copied ? 'i-lucide:check text-green-500' : 'i-lucide:copy'" />
30-36: Await thecopy()call and consider using theDEFAULT_PORTconstant.Two observations:
Per the established pattern in
useInstallCommand.ts(line 86), thecopy()function returns a Promise that should be awaited. This ensures clipboard errors are not silently ignored.The port value
'31415'is hard-coded on lines 8, 22, and 32, whilstDEFAULT_PORTis defined inapp/composables/useConnector.ts(line 57). However, this constant is not currently exported, so you would need to export it from that file first before using it here.♻️ Suggested refactor
-function copyCommand() { +async function copyCommand() { let command = executeNpmxConnectorCommand.value if (portInput.value !== '31415') { command += ` --port ${portInput.value}` } - copy(command) + await copy(command) }To also use
DEFAULT_PORT, you would additionally need to export it fromuseConnector.tsand import it here, then replace the hard-coded'31415'withString(DEFAULT_PORT).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: bc1980bc-d570-4da5-8e72-b7cd49526ace
📒 Files selected for processing (29)
app/components/Header/ConnectorModal.vueapp/components/Package/ManagerSelect.vuei18n/locales/ar.jsoni18n/locales/az-AZ.jsoni18n/locales/bg-BG.jsoni18n/locales/bn-IN.jsoni18n/locales/cs-CZ.jsoni18n/locales/de-DE.jsoni18n/locales/en.jsoni18n/locales/es.jsoni18n/locales/fr-FR.jsoni18n/locales/hi-IN.jsoni18n/locales/hu-HU.jsoni18n/locales/id-ID.jsoni18n/locales/it-IT.jsoni18n/locales/ja-JP.jsoni18n/locales/kn-IN.jsoni18n/locales/nb-NO.jsoni18n/locales/ne-NP.jsoni18n/locales/pl-PL.jsoni18n/locales/pt-BR.jsoni18n/locales/ru-RU.jsoni18n/locales/ta-IN.jsoni18n/locales/te-IN.jsoni18n/locales/tr-TR.jsoni18n/locales/uk-UA.jsoni18n/locales/zh-CN.jsoni18n/locales/zh-TW.jsoni18n/schema.json
💤 Files with no reviewable changes (27)
- i18n/locales/az-AZ.json
- i18n/locales/zh-TW.json
- i18n/locales/id-ID.json
- i18n/locales/bn-IN.json
- i18n/locales/hi-IN.json
- i18n/locales/te-IN.json
- i18n/locales/bg-BG.json
- i18n/locales/ja-JP.json
- i18n/locales/cs-CZ.json
- i18n/locales/en.json
- i18n/locales/es.json
- i18n/schema.json
- i18n/locales/zh-CN.json
- i18n/locales/ar.json
- i18n/locales/tr-TR.json
- i18n/locales/nb-NO.json
- i18n/locales/pl-PL.json
- i18n/locales/ta-IN.json
- i18n/locales/de-DE.json
- i18n/locales/kn-IN.json
- i18n/locales/pt-BR.json
- i18n/locales/ne-NP.json
- i18n/locales/it-IT.json
- i18n/locales/uk-UA.json
- i18n/locales/fr-FR.json
- i18n/locales/hu-HU.json
- i18n/locales/ru-RU.json
🔗 Linked issue
Close #1778
(I'm not sure whether what the issue describe is the same thing as this pr)
🧭 Context
npmx-connectoris now available on npm now📚 Description
This PR removed the warning and finished a todo added in #540. There are some modifies to
ManagerSelect.vueto avoid content overlapping in a modal dialog.