fix(ui): add padding for dependencies + peerDeps#1294
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe pull request updates the Dependencies.vue component file with styling adjustments to dependency list elements. Horizontal padding (px-1 class) has been added to three unordered list elements representing dependencies, peer dependencies, and optional dependencies sections. The aria-label associations have been repositioned to align with the updated list structures in the peer dependencies and optional dependencies sections. These changes are purely styling-related with no modifications to data flow, rendering logic, or exported entities. Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
On the right-hand side, several collapsible sections are displayed. Among these, the simpler ones (containing only a list of strings or links) show inconsistent left-alignment between the
Dependencies.vuecomponent and the corresponding "Maintainers" rendering.This also reveals another issue affecting the rendering of the dependencies lists (regular, optional, and peer) when navigating with the keyboard: the focus styles appear clipped.
Since the
CollapsibleSectioncomponent uses.overflow-hidden, a simple fix may be to apply the same.px-1padding used in the "Maintainers" list rendering.