[BUG] license is undetectable by GitHub #426
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
GitHub cannot detect the license of repos generated with this template. This is due to replacing THE AUTHOR with NPM in the body of the license.
GitHub uses the licensee gem to assert the license for a repo. This is the current state of that:
$ licensee detect lib/content
License: NOASSERTION
Matched files: LICENSE-md.hbs
LICENSE-md.hbs:
Content hash: 7ebb3a715015ea4012998783024bcb45875b75e0
License: NOASSERTION
Closest non-matching licenses:
ISC similarity: 97.81%
0BSD similarity: 81.88%
PostgreSQL similarity: 51.52%
Expected Behavior
No response
Steps To Reproduce
With this change the assertion is successful
--- a/lib/content/LICENSE-md.hbs
+++ b/lib/content/LICENSE-md.hbs
@@ -7,10 +7,10 @@ software for any purpose with or without fee is hereby
granted, provided that the above copyright notice and this
permission notice appear in all copies.
-THE SOFTWARE IS PROVIDED "AS IS" AND NPM DISCLAIMS ALL
+THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL
WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO
-EVENT SHALL NPM BE LIABLE FOR ANY SPECIAL, DIRECT,
+EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS,
WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER$ licensee detect lib/content
License: ISC
Matched files: LICENSE-md.hbs
LICENSE-md.hbs:
Content hash: 7fcb74e2084b361556b8285d6f800495d0d5e36a
Attribution: Copyright npm, Inc.
Confidence: 100.00%
Matcher: Licensee::Matchers::Exact
License: ISC
Environment
No response