-
Notifications
You must be signed in to change notification settings - Fork 25
Closed
Description
The repository URLs are based on assuming that origin is the authoritative url and updates package.json based on this. In the case of this repo, it causes tests to fail locally.
This should be expecting origin to be the default branch to push/pull and upstream to be the authoritative repo because:
- This is the setup recommended by GitHub https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-repository-for-a-fork
- This is what happens if you clone a repo "for contributing to the upstream project" in GitHub desktop
- This is what happens if you clone a repo in VSCode, try to push to that repo, and choose to create a fork when it prompts you to.
Per @lukekarrys in #338 (comment)
@rotu that is due to the autodetection of the
originby git. If you've forked the repo make sure thatnpm/template-ossis theoriginand the remote url for your fork is named something different (egfork):❯ git remotes fork git@github.com:lukekarrys/template-oss.git (fetch) fork git@github.com:lukekarrys/template-oss.git (push) origin git@github.com:npm/template-oss.git (fetch) origin git@github.com:npm/template-oss.git (push)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels