search: Exit early if no arguments provided to search

SimenB · iarna · commit b271ed21e4da · 2016-03-24T17:11:19.000-07:00
Fixes: #11983 PR-URL: #11984 Credit: @SimenB Reviewed-By: @iarna
diff --git a/lib/search.js b/lib/search.js
@@ -49,6 +49,10 @@ function search (args, silent, staleness, cb) {
     return s.toLowerCase()
   }).filter(function (s) { return s })
 
+  if (opts.length === 0) {
+    return cb(new Error('search must be called with arguments'))
+  }
+
   if (typeof searchexclude === 'string') {
     searchexclude = searchexclude.split(/\s+/)
   } else {
diff --git a/test/tap/search.js b/test/tap/search.js
@@ -74,6 +74,20 @@ test('No previous cache, init cache triggered by first search', function (t) {
   })
 })
 
+test('no arguments provided should error', function (t) {
+  common.npm(['search'], [], function (err, code, stdout, stderr) {
+    if (err) throw err
+    t.equal(code, 1, 'search finished unsuccessfully')
+
+    t.match(
+        stderr,
+        /search must be called with arguments/,
+        'should have correct error message'
+    )
+    t.end()
+  })
+})
+
 test('previous cache, _updated set, should trigger since request', function (t) {
   setupCache()
 
