Skip to content

test: update tap + fix tests#426

Closed
louis-bompart wants to merge 1 commit intonpm:mainfrom
louis-bompart:test/fix-tests
Closed

test: update tap + fix tests#426
louis-bompart wants to merge 1 commit intonpm:mainfrom
louis-bompart:test/fix-tests

Conversation

@louis-bompart
Copy link
Contributor

@louis-bompart louis-bompart commented Jan 28, 2022 •
edited
Loading

I had the following error when running npm test

> semver@7.3.5 test
> tap

TypeError: Cannot read properties of undefined (reading 'getFileName')
    at module.exports (node-semver\node_modules\tap\node_modules\caller-path\index.js:4:40) 
    at importJSX (node-semver\node_modules\tap\node_modules\import-jsx\index.js:24:46)      
    at module.exports (node-semver\node_modules\tap\node_modules\treport\lib\index.js:13:18)
    at exports.makeReporter (node-semver\node_modules\tap\bin\run.js:422:23)
    at runTests (node-semver\node_modules\tap\bin\run.js:744:3)
    at mainAsync (node-semver\node_modules\tap\bin\run.js:244:5)
TAP version 13
1..0
# time=1.581ms

Updating tap allowed the to run but failed on test/functions/coerce.js:

 FAIL ​ test/functions/coerce.js 1 failed of 93 43.195ms
 ✖ t.done is not a function

I replaced t.done with t.end, which, as far as I can tell, is used everywhere else.

The test run was then fully green.

References

Related to #401 - Actually the same, just with a more recent version

@louis-bompart
test: update tap + fix tests
563d75e 
 - Updated tap
 - Replaced sole occurence of `tap.done()` by `tap.end()`
@louis-bompart louis-bompart mentioned this pull request Jan 28, 2022
Merged
@lukekarrys lukekarrys mentioned this pull request Feb 26, 2022
Merged
@lukekarrys
Copy link
Contributor

lukekarrys commented Feb 26, 2022

Closing in favor of #433

@lukekarrys lukekarrys closed this Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@louis-bompart @lukekarrys