fix: preserve serialNumber UUID in CycloneDX SBOM output #8837 #8859
+17
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It looks like because our fixture serial number is all |
Contributor
Author
Yup, found it. Even after making it a random- it totally works: let me know if there's something else left. Thank you. |
Member
|
Great, thanks. That's a best effort there and we can land this now once CI is green. Thanks for fixing this. |
wraithgar
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue #8837, BOM files in cyclonedx format created by npm-sbom contain an invalid statically UUID value in the serialNumber field:
"serialNumber": "urn:uuid:***", because it was being redacted each time.This change uses
output.standard()with{ [META]: true, redact: false }to bypass redaction for SBOM output, following the same pattern used inlib/commands/token.jsfor outputting authentication tokens that should not be redacted.Before:
After:
Testing
serialNumbernow displays the complete UUIDReferences
Fixes #8837