Merged
Conversation
Previously, `npmlog` was attempting to enable the progress bar even when logs were paused. This displayed the most recent log (most often an error) for the rest of the process. Fixes #4527
Contributor
Author
|
An easy way to reproduce this issue is when running workspace scripts with With the following packages, the display bug will appear when running > npm pkg get -iwr -ws
{
"workspaces": {
"name": "workspaces",
"version": "1.0.0",
"workspaces": [
"ws1",
"ws2"
]
},
"ws1": {
"name": "ws1",
"version": "1.0.0",
"scripts": {
"test": "sleep 1 && echo error && exit 1"
}
},
"ws2": {
"name": "ws2",
"version": "1.0.0",
"scripts": {
"test": "sleep 1 && echo success"
}
}
}Here is a screenshot of the output before and after this change: |
wraithgar
approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
npmlogwas attempting to enable the progress bar even whenlogs were paused. This displayed the most recent log (most often an
error) for the rest of the process.
Fixes #4527