fix: updated ebadplatform messaging to be generated based on the error#6277
Merged
fix: updated ebadplatform messaging to be generated based on the error#6277
Conversation
Collaborator
|
found 1 benchmarks with statistically significant performance improvements
found 3 benchmarks with statistically significant performance regressions
timing results
|
wraithgar
approved these changes
Mar 21, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the changes here are meant to make it so that the npm cli doesn't have to know about what keys npm-install-checks sets in the
currentandrequiredproperties of the error. to facilitate this, the following changes to output have been made:archhas been renamed tocputo reflect the field in the package.json that is actually being checkedundefinedor a zero-length array in the error'srequiredproperty are removed from the messaging. this can reduce the messaging so users are only shown things that the package actually asked for rather than lettingundefinedand empty strings throughValidandActuallines for the same key are now next to each other instead of having all of the Valids followed by all of the ActualsExample of the previous valid/actual behavior
And the new behavior