Skip to content

fix: npm unstar #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ruyadorno wants to merge 2 commits into from
Closed

fix: npm unstar #2204

ruyadorno wants to merge 2 commits into from

Conversation

@ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Nov 19, 2020

  • Refactored lib/star.js
  • Fixes npm unstar by adding a lib/unstar.js alias/cmd
  • Add tests for lib/star.js and lib/unstar.js

@ruyadorno ruyadorno requested a review from a team as a code owner November 19, 2020 21:22
@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Nov 19, 2020
@ruyadorno
fix: npm unstar
b76ca9d 
- Refactored lib/star.js
- Fixes `npm unstar` by adding a lib/unstar.js alias/cmd
- Add tests for lib/star.js and lib/unstar.js

Fixes: npm/statusboard#174
@ruyadorno ruyadorno self-assigned this Nov 19, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 20 milestone Nov 19, 2020
nlf
nlf approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nlf nlf mentioned this pull request Nov 20, 2020
Merged
@nlf nlf closed this in 5fc56b6 Nov 20, 2020
@ruyadorno ruyadorno mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nlf nlf nlf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ruyadorno ruyadorno

Labels

release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release

Projects

None yet

Milestone

OSS - Sprint 20

Development

Successfully merging this pull request may close these issues.

2 participants

@ruyadorno @nlf