fix(arborist): do not audit in offline mode (#4410)

mohd-akram · web-flow · commit 54cda9697b77 · 2022-02-16T08:37:46.000-08:00
diff --git a/workspaces/arborist/lib/audit-report.js b/workspaces/arborist/lib/audit-report.js
@@ -304,7 +304,7 @@ class AuditReport extends Map {
 
   async [_getReport] () {
     // if we're not auditing, just return false
-    if (this.options.audit === false || this.tree.inventory.size === 1) {
+    if (this.options.audit === false || this.options.offline === true || this.tree.inventory.size === 1) {
       return null
     }
 
diff --git a/workspaces/arborist/test/audit-report.js b/workspaces/arborist/test/audit-report.js
@@ -260,6 +260,24 @@ t.test('audit disabled by config', async t => {
   t.equal(report.error, null, 'no error encountered')
 })
 
+t.test('audit disabled by offline mode', async t => {
+  const path = resolve(fixtures, 'audit-nyc-mkdirp')
+
+  const logs = []
+  const onlog = (...msg) => logs.push(msg)
+  process.on('log', onlog)
+  t.teardown(() => process.removeListener('log', onlog))
+
+  const arb = newArb(path, { offline: true })
+
+  const tree = await arb.loadVirtual()
+  const report = await AuditReport.load(tree, arb.options)
+  t.equal(report.report, null, 'did not get audit response')
+  t.equal(report.size, 0, 'did not find any vulnerabilities')
+  t.match(logs, [], 'no logs of error')
+  t.equal(report.error, null, 'no error encountered')
+})
+
 t.test('one vulnerability', async t => {
   const path = resolve(fixtures, 'audit-one-vuln')
   const auditFile = resolve(path, 'audit.json')

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ class AuditReport extends Map {`
`304`	`304`
`305`	`305`	`async [_getReport] () {`
`306`	`306`	`// if we're not auditing, just return false`
`307`		`- if (this.options.audit === false \|\| this.tree.inventory.size === 1) {`
	`307`	`+ if (this.options.audit === false \|\| this.options.offline === true \|\| this.tree.inventory.size === 1) {`
`308`	`308`	`return null`
`309`	`309`	`}`
`310`	`310`