Add separate schema field for mappings#2123
Closed
austindrenski wants to merge 2 commits intonpgsql:devfrom
Closed
Add separate schema field for mappings#2123austindrenski wants to merge 2 commits intonpgsql:devfrom
austindrenski wants to merge 2 commits intonpgsql:devfrom
Conversation
791013c to
b650b7a
Compare
Contributor
Author
|
It looks like I've broken some tests with "derived" and "inferred" prefixes. This is probably from some of rote updates to the |
1d807cf to
1da76a3
Compare
1da76a3 to
99e5820
Compare
Member
|
@austindrenski are you interested in picking this up again? |
Member
|
Hey @austindrenski, nice to have your back :) Would you like to rebase this and resolve conflicts, or do you want a review before that? |
Member
|
Closing this for age and staleness, plus we haven't seen any user requests for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we have this:
Which contributes to the issues in the EF Core provider involving default schemas and detecting when to escape user defined type names.
npgsql/efcore.pg#605 attempts to address this from the provider-side, but it would be better if the type mapping treated names and schema's separately:
Related